Skip to content

[utils][foreach] Add group tensor by device and dtype util #92014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 3 commits into from
Closed

[utils][foreach] Add group tensor by device and dtype util #92014

janeyx99 wants to merge 3 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 11, 2023

Add util that will be commonly used throughout optim

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92014

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit 15cb7f1:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: foreach_frontend release notes category label Jan 11, 2023
@janeyx99 janeyx99 added the topic: not user facing topic category label Jan 11, 2023
janeyx99
janeyx99 commented Jan 11, 2023
View reviewed changes
torch/optim/adam.py Outdated
Copy link
Contributor Author

@janeyx99 janeyx99 Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crcrpar I've addressed the first two TODOs. CC'ing you in case you have comments!

For the C++ impl, it is likely worth pursuing a general version of this for foreach.

@janeyx99 janeyx99 marked this pull request as ready for review January 11, 2023 18:50
@janeyx99 janeyx99 requested a review from albanD as a code owner January 11, 2023 18:50
albanD
albanD approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 11, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 11, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 11, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 mentioned this pull request Jan 11, 2023
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 11, 2023

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 11, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 11, 2023

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 11, 2023

@pytorchbot merge -f "force merging because i think xla and nvfuser test are just flaky but there are no nice options to let me set + go as of right now"

To elaborate:

  • I would liek to rerun the 11.6 test failure + comment @pytorchbot merge, but I can't do that cuz xla is still running.
  • I could cancel xla and then rerun both, but sunk cost fallacy and the fact that it's been going for over an hour makes me not want to do that
  • I could wait for xla to finish and then rerun just 11.6, but I want to eat dinner and have this merge sooner rather than later
  • I could force merge 😛

If we are autorerunning failed workflows now, it might be nice to not cancel the merge job, but I suspect that would run into timeouts. :/

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 11, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the add-group-by-util branch July 13, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: foreach_frontend release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @pytorchmergebot @albanD