Skip to content

[optim][adadelta] default to foreach when CUDA + differentiable=False #91896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 1 commit into from
Closed

[optim][adadelta] default to foreach when CUDA + differentiable=False #91896

janeyx99 wants to merge 1 commit into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 9, 2023 •
edited
Loading

following up to #90865 and #92048

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91896

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e3e7a3e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 added release notes: nn release notes category topic: performance topic category ciflow/trunk Trigger trunk jobs on your pull request labels Jan 9, 2023
lezcano
lezcano reviewed Jan 10, 2023
View reviewed changes
@janeyx99 janeyx99 marked this pull request as ready for review January 13, 2023 01:52
@janeyx99 janeyx99 requested a review from albanD as a code owner January 13, 2023 01:52
@janeyx99 janeyx99 marked this pull request as draft January 13, 2023 01:53
@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 13, 2023

Did not mean to make this ready for review--this has extra commits that have not landed yet

@janeyx99 janeyx99 force-pushed the adadelta-foreach branch 2 times, most recently from 86b9b51 to a374f19 Compare January 13, 2023 21:41
@janeyx99 janeyx99 marked this pull request as ready for review January 13, 2023 21:58
albanD
albanD approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 13, 2023

@pytorchbot merge

@janeyx99 janeyx99 added the topic: bc breaking topic category label Jan 13, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@janeyx99 janeyx99 mentioned this pull request Jan 14, 2023
Closed
@github-actions github-actions bot deleted the adadelta-foreach branch July 15, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano left review comments

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: bc breaking topic category topic: performance topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janeyx99 @pytorchmergebot @lezcano @albanD