[DTensor] check DeviceMesh ranks contiguity #91802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
XilunWu
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91802
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e2b6a26: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
wanchaol
reviewed
Jan 12, 2023
Collaborator
wanchaol
left a comment
wanchaol
left a comment
There was a problem hiding this comment.
same comment as the previous PR, can we do this check only when we are creating the world_pg?
[ghstack-poisoned]
wanchaol
approved these changes
Jan 12, 2023
| # mesh must be contiguous (i.e. from 0 to N-1) | ||
| if 2 * unique_mesh_values.sum().item() != world_size * (world_size - 1): | ||
| raise RuntimeError( | ||
| f"DeviceMesh is expected to be contiguous, but found {self.mesh.tolist()}" |
Collaborator
There was a problem hiding this comment.
nit: it might not be contiguous as always, i.e. [[0, 2], [1, 3]] Maybe change the error msg to sth like:
DeviceMesh should have all ranks of the world
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):