update vmap to accept nones #91644
Closed
update vmap to accept nones #91644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91644
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 FailuresAs of commit 86e48a6: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
srossross
added
the
release notes: torch.func
mikaylagawarecki
added
the
triaged
srossross
force-pushed
the
feat/vmap-none-pt-2
branch
from
d8a5394 to
5ab7ef6
Compare
Collaborator
kshitij12345
left a comment
kshitij12345
left a comment
There was a problem hiding this comment.
I think we need to add support for returning unbatched tensor and a test for the same.
srossross
force-pushed
the
feat/vmap-none-pt-2
branch
from
5ab7ef6 to
0e77eb4
Compare
kshitij12345
approved these changes
Jan 17, 2023
Collaborator
kshitij12345
left a comment
kshitij12345
left a comment
There was a problem hiding this comment.
LGTM! Thank you @srossross
srossross
force-pushed
the
feat/vmap-none-pt-2
branch
from
0e77eb4 to
a570975
Compare
srossross
force-pushed
the
feat/vmap-none-pt-2
branch
from
a570975 to
86e48a6
Compare
Collaborator
Author
|
@pytorchbot merge --force "Failures are not related to functorch" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonein its out_dims argument functorch#1082