Skip to content

[MPS] Add support for torch.linalg.cross #91642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DenisVieriu97 wants to merge 1 commit into from
Closed

[MPS] Add support for torch.linalg.cross #91642

DenisVieriu97 wants to merge 1 commit into from

Conversation

@DenisVieriu97
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 commented Jan 3, 2023

  • Add support for torch.linalg.cross
  • Make use of metal::cross for float and half. For the other dtypes implement cross manually

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Jan 3, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91642

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit b6b5727:

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Jan 3, 2023
@DenisVieriu97 DenisVieriu97 changed the title [MPS] Add support for torch.linalg.cross (#159) [MPS] Add support for torch.linalg.cross Jan 3, 2023
razarmehr
razarmehr approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 3, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 3, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 4, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

Tried to rebase and push PR #91642, but it was already up to date

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 4, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

Tried to rebase and push PR #91642, but it was already up to date

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 4, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

Successfully rebased cross_mps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cross_mps && git pull --rebase)

@DenisVieriu97
Add support for torch.linalg.cross (#159)
b6b5727 
* Add support for torch.linalg.cross

* Make use of metal::cross for float and half. For the other dtypes implement cross manually
@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 5, 2023

@pytorchbot merge -f "Lint+MPS is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 5, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@razarmehr razarmehr razarmehr approved these changes

@albanD albanD Awaiting requested review from albanD

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DenisVieriu97 @pytorchmergebot @malfet @razarmehr @pytorchbot