Skip to content

[MPS] Add nonzero mps support #91616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DenisVieriu97 wants to merge 4 commits into from
Closed

[MPS] Add nonzero mps support #91616

DenisVieriu97 wants to merge 4 commits into from

Conversation

@DenisVieriu97
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 commented Jan 3, 2023

Adds nonzero support for mps:

Pseudocode:

//
// inputTensor   = [1,  0,  0,  3]
// inputNonZero  = [1,  0,  0,  1] (input != 0)
// scan          = [1,  1,  1,  2] (prefix sum)
// maskedIndices = [0, -1, -1,  1] (select)
// coordinates   = [0,  1,  2,  3] (coordinateAlongAxis)
// scatterResult = [0,  3]         (scatter)

DenisVieriu97 and others added 3 commits January 2, 2023 23:19
@DenisVieriu97
Add nonzero support for mps (#133)
ffe08e9 
* Add nonzero op support for mps

* Fix graph caching for nonzero op (use unranked placeholder for output)

* Add support for nonzero op starting from macOS Ventura. Fallback to CPU for older OS versions
@DenisVieriu97
Fix build failure
5486d26
@DenisVieriu97
Fix remaining build failures
0563f98
@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Jan 3, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91616

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 04afc3c:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Jan 3, 2023
razarmehr
razarmehr approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 3, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 3, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@DenisVieriu97 DenisVieriu97 mentioned this pull request Jan 3, 2023
Open
@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 3, 2023

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 4, 2023

@pytorchbot merge -f "Lint+MPS is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 4, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

malfet
malfet reviewed Jan 4, 2023
View reviewed changes
aten/src/ATen/native/mps/operations/Indexing.mm
return out_;
}

bool contiguous_output = (out_.is_contiguous() && !out_.is_view());
Copy link
Contributor

@malfet malfet Jan 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong (i.e. non-contiguous tensors can sometimes be reported as contiguous and views are sometimes contiguous) Is there an umbrella issue that talks about MPS support for non-contiguous tensors?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet left review comments

@razarmehr razarmehr razarmehr approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DenisVieriu97 @pytorchmergebot @malfet @razarmehr @pytorchbot