[Meta] Register aten.pixel_shuffle.default for meta #91605
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91605
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8ceb796: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Xia-Weiwen
force-pushed
the
fix_issue_91551
branch
from
6685270 to
2e0adca
Compare
Xia-Weiwen
changed the title
jgong5
left a comment
jgong5
left a comment
There was a problem hiding this comment.
LGTM. Add a UT to cover the fixed issue?
Xia-Weiwen
force-pushed
the
fix_issue_91551
branch
from
2e0adca to
ac2dedf
Compare
Xia-Weiwen
force-pushed
the
fix_issue_91551
branch
from
ac2dedf to
8ceb796
Compare
Hi @jgong5 I have added a UT. Please review again. Thanks! |
|
Hi @mingfeima Thanks for your approval. Does that mean this PR can be merged or can be set to ready for review from the Meta side? |
|
Hi @jgong5 @mingfeima Thanks for your approval. Do we need approval from Meta side to land this PR? If so, from whom? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
6 participants
Summary
Fixes #91551
aten.pixel_shuffle.defaultis not registered for meta and it always generates contiguous (channels-first) layout of outputs. It can be reproduced bytorch.compile(as described in the issue #91551) and running in FakeTensorMode.Test plan
python test/inductor/test_torchinductor.py -k test_pixel_shuffle_channels_last
python test/test_proxy_tensor.py
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @Guobing-Chen @chunyuan-w @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @desertfire