Add an option to skip loading of debug traces #91430
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91430
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c09731a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
davidberard98
left a comment
davidberard98
left a comment
There was a problem hiding this comment.
awesome, thanks!
also interesting, I haven't seen the caffe2/serialize code before. Interesting that it's in caffe2/ instead of torch/csrc/. I guess maybe that logic is shared with caffe2?
caffe2/serialize/inline_container.cc
Outdated
There was a problem hiding this comment.
nit: stray debug? or I might have missed where it is used
|
@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Debug traces consumes lots of memory especially for small models. Test Plan: Unit test Reviewers: Subscribers: Tasks: Tags:
|
@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Summary:
Debug traces consumes lots of memory especially for small models.
Test Plan:
Unit test
Reviewers:
Subscribers:
Tasks:
Tags:
Fixes #ISSUE_NUMBER