[MPS] Implement MPSGenerator to enable manual random seeding #91348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kend (#131) This patch will will add support for creating torch.Generator for MPS device, and enables its functions such as manual_seed, get_state, and set_state.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91348
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 09f0a5e: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
albanD
reviewed
Dec 26, 2022
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Sounds good. Only small things
bdhirsh
added
the
triaged
malfet
approved these changes
Dec 29, 2022
Collaborator
Author
|
@pytorchbot merge -f "Other failures are unrelated" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
razarmehr
added a commit
to kulinseth/pytorch
that referenced
this pull request
Jan 3, 2023
…#91348) This patch adds support for creating torch.Generator for MPS device, and enables its functions such as manual_seed, get_state, and set_state. Fixes pytorch#84288 and pytorch#84516 Pull Request resolved: pytorch#91348 Approved by: https://github.com/malfet, https://github.com/albanD
This was referenced Jan 3, 2023
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Feb 6, 2023
…#91348) This patch adds support for creating torch.Generator for MPS device, and enables its functions such as manual_seed, get_state, and set_state. Fixes pytorch#84288 and pytorch#84516 Pull Request resolved: pytorch#91348 Approved by: https://github.com/malfet, https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for creating torch.Generator for MPS device, and enables its functions such as manual_seed, get_state, and set_state.
Fixes #84288 and #84516