Skip to content

[MPS] Add bincount support for mps #91267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DenisVieriu97 wants to merge 3 commits into from
Closed

[MPS] Add bincount support for mps #91267

DenisVieriu97 wants to merge 3 commits into from

Conversation

@DenisVieriu97
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 commented Dec 21, 2022

Add support for bincount on MPS

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Dec 21, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 21, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 62a774b:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Dec 21, 2022
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 22, 2022
razarmehr
razarmehr approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 2, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 2, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@DenisVieriu97 @pytorchmergebot
Add bincount support for mps (#137)
ffc1151 
* Add bincount sopport for mps

* Remove comment

* Remove unnecessary spaces

* Address PR comments

* Add more bincount tests; fix scatter for uint8 dtype

* Add missing comment

* Remove print from test_mps.py
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 2, 2023

Successfully rebased bincount_mps onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout bincount_mps && git pull --rebase)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 2, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 2, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 2, 2023

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 2, 2023

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 2, 2023

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

DenisVieriu97 commented Jan 3, 2023

@pytorchbot merge -f "Lint+MPS is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 3, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@DenisVieriu97 DenisVieriu97 mentioned this pull request Jan 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razarmehr razarmehr razarmehr approved these changes

@malfet malfet Awaiting requested review from malfet

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DenisVieriu97 @pytorchmergebot @razarmehr @pytorchbot @drisspg