[FSDP] Test use_orig_params=True, no_sync(), mixed precision
#91193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
H-Huang,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91193
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d8a9c12: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
…cision" This makes some minor fixes to ensure that `use_orig_params=True`, `no_sync()`, and mixed precision work together for `FULL_SHARD`, `SHARD_GRAD_OP`, and `NO_SHARD`. The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline. [ghstack-poisoned]
awgu
pushed a commit
to awgu/pytorch
that referenced
this pull request
Jan 11, 2023
ghstack-source-id: cefb403 Pull Request resolved: pytorch#91193
This was referenced Jan 11, 2023
zhaojuanmao
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
r's current device iscuda:r#92035 [FSDP][RFC] Enforce rankr's current device iscuda:rdevice_id+ CPU offload test #92031 [FSDP][BE] Improvedevice_id+ CPU offload testprefixed_param_names->fqnsfor consolidation #92028 [FSDP][BE] Renameprefixed_param_names->fqnsfor consolidationuse_orig_params=True#91767 [FSDP] Do not clean FQNs even foruse_orig_params=Trueuse_orig_params=True,no_sync(), mixed precision #91193 [FSDP] Testuse_orig_params=True,no_sync(), mixed precisionMixedPrecisiondocs #91974 [FSDP] ClarifyMixedPrecisiondocsThis makes some minor fixes to ensure that
use_orig_params=True,no_sync(), and mixed precision work together forFULL_SHARD,SHARD_GRAD_OP, andNO_SHARD.The added unit test only checks that dtypes are correct since for FP16, it is hard to test for numeric parity against a baseline.