Skip to content

[autograd Function] Don't materialize forward grad for non-differentiable types #91183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
soulitzer wants to merge 5 commits into from
Closed

[autograd Function] Don't materialize forward grad for non-differentiable types #91183

soulitzer wants to merge 5 commits into from

Conversation

@soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Dec 20, 2022 •
edited
Loading

@soulitzer soulitzer requested a review from albanD as a code owner December 20, 2022 18:21
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 20, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91183

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5963c94:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

soulitzer added a commit that referenced this pull request Dec 20, 2022
@soulitzer
[autograd Function] Don't materialize forward grad for non-differenti…
a03a176 
…able types

ghstack-source-id: 1d977f0
Pull Request resolved: #91183
@soulitzer soulitzer added release notes: autograd release notes category topic: bug fixes topic category labels Dec 20, 2022
@soulitzer soulitzer mentioned this pull request Dec 20, 2022
Closed
zou3519
zou3519 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs a rebase though,

pytorch/test/functorch/test_ops.py

Line 1485 in f8b348c

xfail('NumpySortAutogradFunction'), # https://github.com/pytorch/pytorch/issues/90067
should pass after this change

@soulitzer soulitzer mentioned this pull request Dec 20, 2022
Closed
@soulitzer soulitzer mentioned this pull request Dec 21, 2022
Closed
@soulitzer
Copy link
Contributor Author

soulitzer commented Dec 21, 2022

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 21, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 21, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/soulitzer/157/head branch June 8, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: autograd release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soulitzer @pytorchmergebot @zou3519