Skip to content

86990 range mps support #91075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OwenElliottDev wants to merge 2 commits into from
Closed

86990 range mps support #91075

OwenElliottDev wants to merge 2 commits into from

Conversation

@OwenElliottDev
Copy link
Contributor

@OwenElliottDev OwenElliottDev commented Dec 18, 2022

Fixes #86990

  • Added range_mps_out to RangeFactories.mm
  • Updated native_functions.yaml
  • Added tests in test_mps.py

I did observe that despite the documentation for torch.range, the existing implementations do not adjust their return type based off the arguments passed to them. The MPS implementation provided here behaves the same way as the existing CPU and CUDA implementations in this regard, hence the conversion to float32 in the test cases.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91075

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 044efc5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 18, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: OwenPendrighElliott / name: OwenElliott (c209664)

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 18, 2022
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 22, 2022
@OwenElliottDev
Copy link
Contributor Author

OwenElliottDev commented Jan 1, 2023

Hi @kulinseth, first time contributing - I have signed the CLA and added my email for future commits, do I need to reopen this PR to pass that check or is this one good as it is?

@soumith
Copy link
Contributor

soumith commented Jan 3, 2023

/easycla

@kulinseth
Copy link
Collaborator

kulinseth commented Feb 11, 2023

@OwenPendrighElliott can you please sign up the CLA.

@OwenElliottDev
Copy link
Contributor Author

OwenElliottDev commented Feb 11, 2023

Hi @kulinseth, I have signed the CLA

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 12, 2023

/easycla

@DenisVieriu97 DenisVieriu97 force-pushed the 86990_range_MPS_Support branch from 73d9dcc to addb239 Compare February 12, 2023 09:04
DenisVieriu97
DenisVieriu97 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 12, 2023

@OwenPendrighElliott the changes look good - the CLA it seems that it's still not signed. Can you please make sure you signed it?

@OwenElliottDev
Copy link
Contributor Author

OwenElliottDev commented Feb 12, 2023

@DenisVieriu97 I think my email and user name are missing on the commit which is causing the check to fall over, would you like me to close this PR, commit again and open a new PR? Or is there a better fix?

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 13, 2023

/easycla

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 13, 2023 •
edited by linux-foundation-easycla bot
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: OwenPendrighElliott / name: OwenElliott (3f8f727)

@OwenElliottDev OwenElliottDev force-pushed the 86990_range_MPS_Support branch from addb239 to 1122588 Compare February 13, 2023 08:25
@OwenElliottDev OwenElliottDev force-pushed the 86990_range_MPS_Support branch from 1122588 to c209664 Compare February 13, 2023 08:27
@DenisVieriu97 DenisVieriu97 force-pushed the 86990_range_MPS_Support branch from c209664 to 3f8f727 Compare February 13, 2023 17:34
@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 13, 2023

Thanks @OwenPendrighElliott

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 13, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge failed

Reason: 1 mandatory check(s) failed (Rule MPS). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 13, 2023

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MPS] Add support for aten::range for MPS backend

7 participants

@OwenElliottDev @soumith @kulinseth @DenisVieriu97 @pytorchmergebot @pytorchbot @drisspg