Skip to content

[Checkpoint] Fix checkpoint test test_fsdp_optim_state.py #91036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wz337 wants to merge 2 commits into from
Closed

[Checkpoint] Fix checkpoint test test_fsdp_optim_state.py #91036

wz337 wants to merge 2 commits into from

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Dec 16, 2022 •
edited
Loading

This PR:

  1. Fix the test/distributed/fsdp/test_fsdp_optim_state.py according to change in FSDP.flatten_sharded_optim_state_dict() API.
  2. Update docstring accordingly.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 16, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91036

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4c77c6f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Dec 16, 2022
@wz337 wz337 requested a review from fegin December 16, 2022 20:55
@wz337 wz337 marked this pull request as ready for review December 16, 2022 20:55
fegin
fegin approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wz337
Copy link
Contributor Author

wz337 commented Dec 16, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@wz337
Copy link
Contributor Author

wz337 commented Dec 16, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Successfully rebased fix_test_fsdp_optim_state.py onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_test_fsdp_optim_state.py && git pull --rebase)

@wz337 wz337 changed the title [Checkpoint] Fix checkpoint test test_fsdp_state_dict.py [Checkpoint] Fix checkpoint test test_fsdp_optim_state.py Dec 16, 2022
@wz337
Copy link
Contributor Author

wz337 commented Dec 16, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@wz337 wz337 mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wz337 @pytorchmergebot @fegin