Skip to content

Conversation

@min-jean-cho
Copy link
Collaborator

Re-landing #86706

This PR adds linear-batchnormNd folding for JIT frozen graphs.

Performance benchmark
A preliminary benchmark with a simple model of linear+bn1d tested on first socket, physical cores of skylake machine.

FP32, JIT
without linear-bn folding
Screenshot (1368)

with linear-bn folding
Screenshot (1367)

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 16, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91020

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 08fc51d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Dec 16, 2022
@facebook-github-bot
Copy link
Contributor

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@min-jean-cho
Copy link
Collaborator Author

@davidberard98 looks like all CIs have passed this time!

Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But let me try landing it this time, I'll check internally first

@davidberard98 davidberard98 added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2022
@davidberard98
Copy link
Contributor

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased minjean/reland_lin_bn_folding onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/reland_lin_bn_folding && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the minjean/reland_lin_bn_folding branch from 3d94c55 to 76acf2d Compare December 18, 2022 03:59
@facebook-github-bot
Copy link
Contributor

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@davidberard98
Copy link
Contributor

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased minjean/reland_lin_bn_folding onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout minjean/reland_lin_bn_folding && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the minjean/reland_lin_bn_folding branch from 76acf2d to 08fc51d Compare December 19, 2022 22:01
@facebook-github-bot
Copy link
Contributor

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants