Fix MAGMA svd and eig #9082
Closed
Fix MAGMA svd and eig #9082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
approved these changes
Jul 1, 2018
Collaborator
Author
|
cc @vishwakftw |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ssnl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vishwakftw
reviewed
Jul 1, 2018
test/test_cuda.py
Outdated
| ('inverse', new_t(20, 20), lambda t: [], None, float_types, False), | ||
| ('geqrf', new_t(20, 20), lambda t: [], None, float_types, False, | ||
| unittest.skipIf(not TEST_MAGMA, "no MAGMA library detected")), | ||
| ('svd', new_t(10, 10), lambda t: [], 'square', float_types, False, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ssnl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ssnl is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 2, 2018
Summary: Fixes pytorch/pytorch#9079 There is room for speed-up for both functions (see pytorch/pytorch#9083), but let's get this in to unblock #9052 . Closes pytorch/pytorch#9082 Reviewed By: ezyang Differential Revision: D8711687 Pulled By: SsnL fbshipit-source-id: f043a9bf55cb6aec5126c3331d35761f7aa3f8e3
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Fixes pytorch/pytorch#9079 There is room for speed-up for both functions (see pytorch/pytorch#9083), but let's get this in to unblock #9052 . Closes pytorch/pytorch#9082 Reviewed By: ezyang Differential Revision: D8711687 Pulled By: SsnL fbshipit-source-id: f043a9bf55cb6aec5126c3331d35761f7aa3f8e3
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Fixes pytorch#9079 There is room for speed-up for both functions (see pytorch#9083), but let's get this in to unblock pytorch#9052 . Closes pytorch#9082 Reviewed By: ezyang Differential Revision: D8711687 Pulled By: SsnL fbshipit-source-id: f043a9bf55cb6aec5126c3331d35761f7aa3f8e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9079
There is room for speed-up for both functions (see #9083), but let's get this in to unblock #9052 .