Add VmapInterpreter.randomness (in pyfunctorch) provide it in info object #90789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject This PR: - adds VmapInterpreter.randomness. This returns the randomness option the user provided in vmap(..., randomness=...) - adds randomness in the info object passed to the vmap staticmethod of autograd.Function. This is so that the user can handle random operations on their own terms (if randomness="error", and if the autograd.Function has random operations, then it is the user's responsiblity to raise an error). Test Plan: - updated unittest [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90789
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit e29ae66: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 13, 2022
zou3519
added a commit
that referenced
this pull request
Dec 13, 2022
…ject This PR: - adds VmapInterpreter.randomness. This returns the randomness option the user provided in vmap(..., randomness=...) - adds randomness in the info object passed to the vmap staticmethod of autograd.Function. This is so that the user can handle random operations on their own terms (if randomness="error", and if the autograd.Function has random operations, then it is the user's responsiblity to raise an error). Test Plan: - updated unittest ghstack-source-id: 46713c7 Pull Request resolved: #90789
zou3519
added
the
release notes: torch.func
samdow
approved these changes
Dec 14, 2022
This was referenced Dec 15, 2022
Closed
… in info object" This PR: - adds VmapInterpreter.randomness. This returns the randomness option the user provided in vmap(..., randomness=...) - adds randomness in the info object passed to the vmap staticmethod of autograd.Function. This is so that the user can handle random operations on their own terms (if randomness="error", and if the autograd.Function has random operations, then it is the user's responsiblity to raise an error). Test Plan: - updated unittest [ghstack-poisoned]
soulitzer
approved these changes
Dec 16, 2022
Contributor
|
This pull request has been merged in ffa37c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR:
the user provided in vmap(..., randomness=...)
autograd.Function. This is so that the user can handle random operations
on their own terms (if randomness="error", and if the autograd.Function
has random operations, then it is the user's responsiblity to raise an
error).
Test Plan: