[Quant] Update IDeep to support oneDNN conv add fusion #90605

leslie-fang-intel · 2022-12-10T04:17:13Z

Stack from ghstack (oldest at bottom):

Summary
This PR updates IDeep to support oneDNN conv add fusion.

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @gujinghui @PenghuiCheng @XiaobingSuper @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen

[ghstack-poisoned]

pytorch-bot · 2022-12-10T04:17:15Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90605

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b6edd11:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep change in this PR points to my personal repo currently for test purpose. After the changes landed in IDeep main branch, need to point IDeep changes to the main branch. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

Xia-Weiwen · 2022-12-11T09:07:18Z

Hi @leslie-fang-intel Please sync with @yanbing-j for updating ideep in stock PT. Now all PRs to update ideep are opened and managed by her.

jgong5

Weird that I cannot add @yanbing-j as a reviewer. LGTM but needs Yanbing to stamp on it too.

yanbing-j · 2022-12-12T05:03:32Z

Maybe I have no permission, so that I cannot be added as a reviewer.
Hi @leslie-fang-intel , you can submit PR in ideep_pytorch first. Then rebase this PR to include ideep changes.

leslie-fang-intel · 2022-12-12T05:06:56Z

Maybe I have no permission, so that I cannot be added as a reviewer. Hi @leslie-fang-intel , you can submit PR in ideep_pytorch first. Then rebase this PR to include ideep changes.

@yanbing-j Yes, here is the PR to ideep_pytorch (intel/ideep#148), it's still waiting @jgong5 review.

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep change in this PR points to my personal repo currently for test purpose. After the changes landed in IDeep main branch, need to point IDeep changes to the main branch. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

ghstack-source-id: caaf16b Pull Request resolved: #90605

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep change in this PR points to my personal repo currently for test purpose. After the changes landed in IDeep main branch, need to point IDeep changes to the main branch. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

**Summary** This PR updates IDeep to support oneDNN conv add fusion. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep still points to personal repo. After necessary IDeep PR merged, will point it to right position. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

ghstack-source-id: 2c573d4 Pull Request resolved: pytorch#90605

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep still points to personal repo. After necessary IDeep PR merged, will point it to right position. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

ghstack-source-id: a730cb6 Pull Request resolved: pytorch#90605

**Summary** This PR updates IDeep to support oneDNN conv add fusion. **TODO** The IDeep still points to personal repo. After necessary IDeep PR merged, will point it to right position. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

leslie-fang-intel · 2023-01-05T01:48:03Z

@pytorchbot rebase

pytorchmergebot · 2023-01-05T01:49:46Z

@pytorchbot successfully started a rebase job. Check the current status here

**Summary** This PR updates IDeep to support oneDNN conv add fusion. cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen gujinghui PenghuiCheng XiaobingSuper mingfeima sanchitintel ashokei jingxu10 min-jean-cho yanbing-j Guobing-Chen [ghstack-poisoned]

pytorchmergebot · 2023-01-05T01:50:02Z

Successfully rebased gh/leslie-fang-intel/11/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/90605)

ghstack-source-id: d1bed75 Pull Request resolved: #90605

leslie-fang-intel · 2023-01-05T01:50:47Z

@pytorchbot merge

pytorchmergebot · 2023-01-05T01:52:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-01-05T06:14:45Z

Merge failed

Reason: The following mandatory check(s) failed (Rule IDEEP):

pull

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

leslie-fang-intel · 2023-01-05T23:57:09Z

@pytorchbot merge

pytorchmergebot · 2023-01-05T23:58:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2023-01-06T14:51:31Z

Please note, that one would not be able to use any of the new onednn/ideep/mkldnn features in the codebase until it could also be upgraded in Meta's internal checkout which is currently blocked by the fact that mkldnn is checked out twice, see #90264 (comment)

jgong5 · 2023-01-07T01:48:33Z

Please note, that one would not be able to use any of the new onednn/ideep/mkldnn features in the codebase until it could also be upgraded in Meta's internal checkout which is currently blocked by the fact that mkldnn is checked out twice, see #90264 (comment)

Thanks for the note. We are working on a solution to avoid the checked out twice issue. Will keep you updated.

[Quant] Update IDeep to support oneDNN conv add fusion

a3b8c82

[ghstack-poisoned]

pytorch-bot bot added the topic: not user facing topic category label Dec 10, 2022

This was referenced Dec 10, 2022

[Quant] Remove all the dequant nodes when the ref module has multi input args #90157

Closed

[Quant] Add fused conv2d_add op for onednn backend #90262

Closed

[Quant] Add fused conv2d_add_relu op for onednn backend #90364

Closed

github-actions bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Dec 10, 2022

leslie-fang-intel marked this pull request as draft December 10, 2022 04:17

leslie-fang-intel added intel This tag is for PR from Intel ciflow/trunk Trigger trunk jobs on your pull request oncall: quantization Quantization support in PyTorch labels Dec 10, 2022

leslie-fang-intel requested review from Xia-Weiwen and jgong5 December 10, 2022 04:22

pytorchbot added the open source label Dec 10, 2022

jgong5 approved these changes Dec 12, 2022

View reviewed changes

leslie-fang-intel added a commit that referenced this pull request Dec 14, 2022

[Quant] Update IDeep to support oneDNN conv add fusion

62be733

ghstack-source-id: caaf16b Pull Request resolved: #90605

leslie-fang-intel mentioned this pull request Dec 14, 2022

[Quant] Use the true src zero point to query and create conv pd #90818

Closed

leslie-fang-intel added 2 commits December 16, 2022 08:09

leslie-fang-intel marked this pull request as ready for review December 16, 2022 00:23

leslie-fang-intel added 3 commits December 19, 2022 17:00

leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Dec 19, 2022

[Quant] Update IDeep to support oneDNN conv add fusion

ff198c9

ghstack-source-id: 2c573d4 Pull Request resolved: pytorch#90605

leslie-fang-intel mentioned this pull request Dec 20, 2022

[Quant] Add fused ConvAdd2d module for onednn backend #91152

Closed

This was referenced Dec 20, 2022

[Quant][FX] Lower QConvAdd2d for onednn backend #91153

Closed

[Quant] Add fused ConvAddReLU2d module for onednn backend #91154

Closed

[Quant][FX] Lower QConvAddReLU2d for onednn backend #91155

Closed

leslie-fang-intel added 2 commits December 20, 2022 15:11

leslie-fang-intel added a commit to leslie-fang-intel/pytorch that referenced this pull request Dec 20, 2022

[Quant] Update IDeep to support oneDNN conv add fusion

a809ffe

ghstack-source-id: a730cb6 Pull Request resolved: pytorch#90605

leslie-fang-intel added 2 commits January 4, 2023 10:22

pytorchmergebot pushed a commit that referenced this pull request Jan 5, 2023

[Quant] Update IDeep to support oneDNN conv add fusion

a70260d

ghstack-source-id: d1bed75 Pull Request resolved: #90605

pytorchmergebot added the Merged label Jan 5, 2023

pytorchmergebot closed this in b2c68c1 Jan 5, 2023

facebook-github-bot deleted the gh/leslie-fang-intel/11/head branch June 8, 2023 17:51

[Quant] Update IDeep to support oneDNN conv add fusion #90605

[Quant] Update IDeep to support oneDNN conv add fusion #90605

Uh oh!

Conversation

leslie-fang-intel commented Dec 10, 2022 • edited by pytorchmergebot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90605

✅ No Failures

Uh oh!

Xia-Weiwen commented Dec 11, 2022

Uh oh!

jgong5 left a comment

Choose a reason for hiding this comment

Uh oh!

yanbing-j commented Dec 12, 2022

Uh oh!

leslie-fang-intel commented Dec 12, 2022

Uh oh!

leslie-fang-intel commented Jan 5, 2023

Uh oh!

pytorchmergebot commented Jan 5, 2023

Uh oh!

pytorchmergebot commented Jan 5, 2023

Uh oh!

leslie-fang-intel commented Jan 5, 2023

Uh oh!

pytorchmergebot commented Jan 5, 2023

Merge started

Uh oh!

pytorchmergebot commented Jan 5, 2023

Merge failed

Uh oh!

leslie-fang-intel commented Jan 5, 2023

Uh oh!

pytorchmergebot commented Jan 5, 2023

Merge started

Uh oh!

malfet commented Jan 6, 2023

Uh oh!

jgong5 commented Jan 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

leslie-fang-intel commented Dec 10, 2022 •

edited by pytorchmergebot

Loading

pytorch-bot bot commented Dec 10, 2022 •

edited

Loading