Skip to content

[c10d] update alltoall signature to be more consistent #90569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wanchaol wants to merge 5 commits into from
Closed

[c10d] update alltoall signature to be more consistent #90569

wanchaol wants to merge 5 commits into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Dec 9, 2022 •
edited
Loading

@wanchaol
[c10d] update alltoall signature to be more consistent
32e2fee 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

[ghstack-poisoned]
@wanchaol wanchaol mentioned this pull request Dec 9, 2022
Closed
@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Dec 9, 2022
@wanchaol wanchaol mentioned this pull request Dec 9, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90569

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 26f3fb2:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wanchaol wanchaol mentioned this pull request Dec 9, 2022
Closed
wanchaol added a commit that referenced this pull request Dec 9, 2022
@wanchaol
[c10d] update alltoall signature to be more consistent
ca9f3e6 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

ghstack-source-id: a3aada3
Pull Request resolved: #90569
@wanchaol wanchaol added the module: bc-breaking Related to a BC-breaking change label Dec 9, 2022
@pytorch-bot pytorch-bot bot added the topic: bc breaking topic category label Dec 9, 2022
@wanchaol
Update on "[c10d] update alltoall signature to be more consistent"
ad741b5 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

cc ezyang gchanan

[ghstack-poisoned]
@wanchaol wanchaol mentioned this pull request Dec 12, 2022
Closed
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 12, 2022
@wanchaol
Copy link
Collaborator Author

wanchaol commented Dec 12, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2022

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ca602434dda2b013d4f076811d20c868224c7feb returned non-zero exit code 1

Auto-merging torch/csrc/distributed/c10d/Ops.cpp
CONFLICT (modify/delete): torch/csrc/distributed/c10d/OpsImpl.cpp deleted in HEAD and modified in ca602434dd (Add alltoall_ to CommTensor).  Version ca602434dd (Add alltoall_ to CommTensor) of torch/csrc/distributed/c10d/OpsImpl.cpp left in tree.
error: could not apply ca602434dd... Add alltoall_ to CommTensor
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@wanchaol
Update on "[c10d] update alltoall signature to be more consistent"
85772b3 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

cc ezyang gchanan

[ghstack-poisoned]
@wanchaol
Update on "[c10d] update alltoall signature to be more consistent"
3ea5136 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

cc ezyang gchanan

[ghstack-poisoned]
@wanchaol
Update on "[c10d] update alltoall signature to be more consistent"
26f3fb2 
alltoall signature should be more consistent with its argument
updated and this should be a BC breaking change

cc ezyang gchanan

[ghstack-poisoned]
@wanchaol
Copy link
Collaborator Author

wanchaol commented Dec 13, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 13, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 13, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@wanchaol
Copy link
Collaborator Author

wanchaol commented Dec 13, 2022

@pytorchbot merge -f "failures not related"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 13, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/232/head branch June 8, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change release notes: distributed (c10d) release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wanchaol @pytorchmergebot @mrshenli