Skip to content

[MPS] Add Inverse op. #90428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulinseth wants to merge 4 commits into from
Closed

[MPS] Add Inverse op. #90428

kulinseth wants to merge 4 commits into from

Conversation

@kulinseth
Copy link
Collaborator

@kulinseth kulinseth commented Dec 8, 2022

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 8, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90428

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b7a1bae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 8, 2022
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 9, 2022
DenisVieriu97
DenisVieriu97 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

DenisVieriu97
DenisVieriu97 reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build still seems to be failing due to missing selector for inverseOfTensor

DenisVieriu97
DenisVieriu97 requested changes Dec 12, 2022
View reviewed changes
@DenisVieriu97 DenisVieriu97 mentioned this pull request Dec 14, 2022
Merged
@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Dec 16, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 16, 2022

Successfully rebased op/inverse onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout op/inverse && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Dec 19, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 19, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 19, 2022

Successfully rebased op/inverse onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout op/inverse && git pull --rebase)

@malfet
Copy link
Contributor

malfet commented Dec 19, 2022

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 19, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

@razarmehr razarmehr Awaiting requested review from razarmehr

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kulinseth @DenisVieriu97 @pytorchmergebot @malfet @soulitzer @pytorchbot