[pyfunctorch] Generate a more meaningful name for _SingleLevelAutogradFunction #90418
Conversation
…dFunction The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90418
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f1541f3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…evelAutogradFunction" The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
…evelAutogradFunction" The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
…evelAutogradFunction" The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
…evelAutogradFunction" The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
…evelAutogradFunction" The API to do this is not pretty, but at least it works. Test Plan: - new test [ghstack-poisoned]
| # a given name. A Tensor's .grad_fn field has a class name that is the original | ||
| # autograd.Function's name + Backward, so we do this to generate some | ||
| # meaningful name. | ||
| name = f'{autograd_function.__name__}Generated' |
There was a problem hiding this comment.
Don't feel super strongly about this, but just to bike-shed on the name a little, would SingleLayer be more informative than Generated to users at least since someone reading FuncGeneratedBackward might assume that Generated modifies Backward?
There was a problem hiding this comment.
Sorry I hit merge before seeing this. Added it to the follow-ups issue.
I agree SingleLayer makes more sense.
|
@pytorchbot merge -f "test failure is unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack:
The API to do this is not pretty, but at least it works.
Test Plan: