Skip to content

[SDPA] Fix alignment check for efficient_attention #90413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drisspg wants to merge 8 commits into from
Closed

[SDPA] Fix alignment check for efficient_attention #90413

drisspg wants to merge 8 commits into from

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Dec 7, 2022 •
edited
Loading

Fixes a bug found using head_dim_size==100 on an a100 gpu. This PR contains stricter guards on the input shape. These constraints are taken from xformers: https://github.com/facebookresearch/xformers/blob/gh/danthe3rd/60/orig/xformers/ops/fmha/cutlass.py#L23

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90413

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 1c7bc96:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg marked this pull request as ready for review December 7, 2022 22:04
@drisspg drisspg requested a review from cpuhrsch December 7, 2022 22:04
@drisspg drisspg changed the title alignment value should be 8 for sm75+ 16bit types [SDP] Fix alignment check for efficient_attention Dec 7, 2022
@drisspg drisspg force-pushed the update_sdp_constraints branch from fca3a48 to 114953f Compare December 7, 2022 22:13
@pytorch pytorch deleted a comment from pytorch-bot bot Dec 7, 2022
@drisspg
Copy link
Contributor Author

drisspg commented Dec 7, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 7, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 7, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@drisspg drisspg force-pushed the update_sdp_constraints branch from 114953f to 6615758 Compare December 8, 2022 00:46
danthe3rd
danthe3rd reviewed Dec 8, 2022
View reviewed changes
@drisspg drisspg force-pushed the update_sdp_constraints branch 2 times, most recently from c186cf1 to 6f3e76d Compare December 8, 2022 21:35
@drisspg drisspg force-pushed the update_sdp_constraints branch from 5978173 to cf15ace Compare December 9, 2022 05:16
@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Tried to rebase and push PR #90413, but it was already up to date

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Tried to rebase and push PR #90413, but it was already up to date

@drisspg drisspg force-pushed the update_sdp_constraints branch from cf15ace to 1c7bc96 Compare December 9, 2022 17:05
@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot merge -f "unrelated to my changes"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@drisspg drisspg changed the title [SDP] Fix alignment check for efficient_attention [SDPA] Fix alignment check for efficient_attention Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danthe3rd danthe3rd danthe3rd left review comments

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

+1 more reviewer

@mikekgfb mikekgfb mikekgfb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drisspg @pytorchmergebot @danthe3rd @mikekgfb