Skip to content

Conversation

@jcaip
Copy link
Contributor

@jcaip jcaip commented Dec 6, 2022

Stack from ghstack (oldest at bottom):

Summary:
Need this to fix test_public_bindings.

Test Plan:
python test/test_public_bindings.py
Reviewers:

Subscribers:

Tasks:

Tags:

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90315

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8f64759:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the release notes: quantization release notes category label Dec 6, 2022
jcaip added 2 commits December 6, 2022 14:12
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Summary:
Need this to fix `test_public_bindings`. 

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Rebased gh/jcaip/13/orig onto refs/remotes/origin/viable/strict because #89777 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/90315)

@jcaip jcaip changed the title Fix public bindings for DTypeWithConstraint [quant]Fix public bindings for DTypeWithConstraint Dec 7, 2022
@jcaip jcaip added the topic: bug fixes topic category label Dec 7, 2022
Copy link
Contributor

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jcaip
Copy link
Contributor Author

jcaip commented Dec 7, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
Summary:
Need this to fix `test_public_bindings`.

Test Plan:
`python test/test_public_bindings.py`
Reviewers:

Subscribers:

Tasks:

Tags:
Pull Request resolved: pytorch#90315
Approved by: https://github.com/HDCharles
@facebook-github-bot facebook-github-bot deleted the gh/jcaip/15/head branch June 8, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend release notes: quantization release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants