-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[fx] Have replace_pattern return replaced nodes #90244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90244
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit f73fc37: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
2ba6b59 to
ab5c1b4
Compare
ab5c1b4 to
f5d80ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
SherlockNoMad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comment.
f5d80ff to
0c73413
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
0c73413 to
39a6d49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
39a6d49 to
3200ddc
Compare
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: 5f3a9f9be06d9df4edd11698b379c86a9a290ed5
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
3200ddc to
f73fc37
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (
List[Tuple[Match, List[Node]]]). This allows us to easily modify the replaced nodes, including setting the metadata.Test Plan: CI
Differential Revision: D41737056