[dtensor] handle the case where output of op is Optional[Tensor] #90241
Conversation
Observed by @aazzolini, some op might have Optional[Tensor] returns where it return None (i.e. native_layer_norm_backward), it's a mismatch between C++ aten op signature and python None, but we need to handle it in the python side [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90241
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit afc4c4b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ensor]" Observed by aazzolini, some op might have Optional[Tensor] returns where it return None (i.e. native_layer_norm_backward), it's a mismatch between C++ aten op signature and python None, but we need to handle it in the python side [ghstack-poisoned]
wanchaol
added
topic: not user facing
aazzolini
left a comment
aazzolini
left a comment
There was a problem hiding this comment.
Typing wise you'll also have to modify the signature for OutputSharding as well. Gotta return a Sequence[Optional[DTensorSpec]] (instead of Sequence[DTensorSpec])
…ensor]" Observed by aazzolini, some op might have Optional[Tensor] returns where it return None (i.e. native_layer_norm_backward), it's a mismatch between C++ aten op signature and python None, but we need to handle it in the python side [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: linux-binary-manywheel ,linux-binary-manywheel / manywheel-py3_7-cuda11_6-test / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "failure not related" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…orch#90241) Observed by @aazzolini, some op might have Optional[Tensor] returns where it return None (i.e. native_layer_norm_backward), it's a mismatch between C++ aten op signature and python None, but we need to handle it in the python side Pull Request resolved: pytorch#90241 Approved by: https://github.com/aazzolini
Stack from ghstack (oldest at bottom):
Observed by @aazzolini, some op might have Optional[Tensor] returns
where it return None (i.e. native_layer_norm_backward), it's a mismatch
between C++ aten op signature and python None, but we need to handle it
in the python side