Skip to content

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Dec 5, 2022

We updated filesystem.py and added two params to FileSystemWriter: thread_count and per_thread_copy_ahead in this pr(#87987).

This PR updated test_file_system_checkpoint.py to incorporate thread_count in unit tests.

Note: Using @parametrize would result in timeout in CI so that we are manually creating two tests for thread_count 1 and 2 for each existing test.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 5, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90231

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit c1911d8:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review December 5, 2022 23:23
@wz337 wz337 requested a review from fduwjj December 5, 2022 23:23
@wz337
Copy link
Contributor Author

wz337 commented Dec 6, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #90231, but it was already up to date

@wz337
Copy link
Contributor Author

wz337 commented Dec 9, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update_test_file_system_checkpoint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_test_file_system_checkpoint && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Dec 14, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update_test_file_system_checkpoint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_test_file_system_checkpoint && git pull --rebase)

@wz337 wz337 marked this pull request as draft December 15, 2022 22:36
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Feb 13, 2023
@wz337 wz337 closed this by deleting the head repository Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants