-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Checkpoint] Update test_file_system_checkpoint.py #90231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90231
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit c1911d8: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Tried to rebase and push PR #90231, but it was already up to date |
|
@pytorchmergebot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
|
@pytorchmergebot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
We updated filesystem.py and added two params to FileSystemWriter: thread_count and per_thread_copy_ahead in this pr(#87987).
This PR updated test_file_system_checkpoint.py to incorporate thread_count in unit tests.
Note: Using @parametrize would result in timeout in CI so that we are manually creating two tests for thread_count 1 and 2 for each existing test.