Skip to content

Fix XLA dynamo CI #90229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JackCaoG wants to merge 1 commit into from
Closed

Fix XLA dynamo CI #90229

JackCaoG wants to merge 1 commit into from

Conversation

@JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Dec 5, 2022 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90229

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d5d888b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@JackCaoG JackCaoG requested a review from ezyang December 5, 2022 22:31
voznesenskym
voznesenskym reviewed Dec 5, 2022
View reviewed changes
torch/_dynamo/optimizations/backends.py Outdated
Copy link
Collaborator

@voznesenskym voznesenskym Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try:

  1. Moving the model = subgraph.model outside the fwd

or

  1. Removing the del

Copy link
Collaborator Author

@JackCaoG JackCaoG Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah OK, I can do 1 I guess. What's the motivation of del in first place?

Copy link
Collaborator Author

@JackCaoG JackCaoG Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 works, updated the pr.

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Dec 5, 2022

I manually verified this will fix pytorch/xla CI. given this part of the code is only being used by xla, I think it is safe to force merge after approval.

@JackCaoG JackCaoG force-pushed the jackcao/fix_xla_dynamo_ci branch from b422bdc to d5d888b Compare December 5, 2022 22:34
@voznesenskym
Copy link
Collaborator

voznesenskym commented Dec 5, 2022

@pytorchbot merge -f "Force push fix"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 5, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@deandyu deandyu mentioned this pull request Dec 9, 2022
Closed
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@JackCaoG @kulinseth
Fix XLA dynamo CI (pytorch#90229)
e679258 
Fixes pytorch/xla#4274

We should not access `subgraph` once it is deleted.

Pull Request resolved: pytorch#90229
Approved by: https://github.com/voznesenskym
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@voznesenskym voznesenskym voznesenskym approved these changes

@shunting314 shunting314 Awaiting requested review from shunting314

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Master CI is failing

4 participants

@JackCaoG @voznesenskym @pytorchmergebot @pytorchbot