[wip] Move dropout to ATen; deprecate Dropout*d with FeatureDropout #9008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ssnl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ngimel
reviewed
Jun 29, 2018
aten/src/ATen/native/Dropout.cpp
Outdated
|
|
||
| Tensor dropout(const Tensor& self, double p, bool featurewise, bool train, Generator *gen) { | ||
| AT_CHECK(0 <= p && p <= 1, "dropout() expects 0 <= p <= 1, but got p = ", p); | ||
| if (train) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ssnl
requested review from
Yangqing,
anderspapitto,
bddppq,
dzhulgakov,
houseroad,
jamesr66a and
smessmer
as code owners
This was referenced Jun 30, 2018
Contributor
|
@ssnl take a look at the failing tests when you have time? |
Collaborator
Author
|
@weiyangfb This can't be done at the moment. See #9069. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: