[Quant][fx][bc-breaking] Remove unused functions in fx/utils.py #90025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90025
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 192dd2c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ls.py" Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Dec 1, 2022
Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo ghstack-source-id: c27401b Pull Request resolved: #90025
Contributor
|
looks good to me |
HDCharles
approved these changes
Dec 2, 2022
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 additional jobs have failed, first few of them are: linux-binary-manywheel ,linux-binary-manywheel / manywheel-py3_7-cuda11_6-test / build Details for Dev Infra teamRaised by workflow job |
…ls.py" Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
…ls.py" Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Dec 5, 2022
Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo ghstack-source-id: 01dbf06 Pull Request resolved: #90025
…ls.py" Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Dec 6, 2022
Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo ghstack-source-id: 5c2679e Pull Request resolved: #90025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…rch#90025) Summary and BC-breaking notes: This commit removes the following unused functions from both the `torch.quantization` and the `torch.ao.quantization` namespaces: ``` graph_pretty_str get_per_tensor_qparams quantize_node get_qconv_op create_qparam_nodes node_return_type_is_int is_get_tensor_info_node ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestAOMigrationQuantizationFx Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo Pull Request resolved: pytorch#90025 Approved by: https://github.com/HDCharles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary and BC-breaking notes: This commit removes the following
unused functions from both the
torch.quantizationand thetorch.ao.quantizationnamespaces:Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestAOMigrationQuantizationFx
Reviewers: jerryzh168, vkuzo
Subscribers: jerryzh168, vkuzo