[FSDP][optim_state_dict][5/N] Remove optim_inputs for sharded state_dict. #89981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict. [ghstack-poisoned]
fegin
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89981
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 30b1454: The following jobs failed but were likely due to broken trunk (merge base 41c3b41):This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
This was referenced Dec 1, 2022
[FSDP][optim_state_dict][3/N] Support use_orig_param optim_state_dict (non-broadcast version)
#89900
Closed
awgu
approved these changes
Dec 1, 2022
Collaborator
awgu
left a comment
awgu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for cleaning this up :)
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
…ded state_dict." The argument, `optim_inputs`, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -f "The failing test is not related." |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The argument,
optim_inputs, is being deprecated. Sharded optimizer state_dict APIs are not be used. It is safe to remove them.