[FSDP][optim_state_dict][4/N] Remove the unused _get_flat_param_to_fsdp_module API #89980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dp_module API [ghstack-poisoned]
fegin
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89980
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit d790cdf: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 1, 2022
[FSDP][optim_state_dict][3/N] Support use_orig_param optim_state_dict (non-broadcast version)
#89900
Closed
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
…param_to_fsdp_module API" This is an easy PR, just remove an unused internal API. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -f "The failing test is not related." |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is an easy PR, just remove an unused internal API.