Skip to content

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Nov 30, 2022

Stack from ghstack (oldest at bottom):

formatting stack to make dtensor and tp align with pytorch format standard.

cmd: ufmt format test/distributed/tensor

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 30, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89970

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 932ef81:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wanchaol wanchaol requested a review from fduwjj December 1, 2022 01:04
wanchaol added a commit that referenced this pull request Dec 1, 2022
ghstack-source-id: 63261f0
Pull Request resolved: #89970
wanchaol added a commit that referenced this pull request Dec 1, 2022
ghstack-source-id: 0bad3d4
Pull Request resolved: #89970
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 1, 2022
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wanchaol
Copy link
Collaborator Author

wanchaol commented Dec 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
formatting stack to make dtensor and tp align with pytorch format standard.

cmd: `ufmt format test/distributed/tensor`
Pull Request resolved: pytorch#89970
Approved by: https://github.com/fduwjj
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/224/head branch June 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants