[Checkpoint][2D][5/N] Add checkpoint_utils for distributed checkpoint to testing/_internal/distributed/ #89873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89873
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4421902: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wz337
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
XilunWu
approved these changes
Nov 29, 2022
Contributor
XilunWu
left a comment
XilunWu
left a comment
There was a problem hiding this comment.
lgtm. adding new util func.
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge failedReason: Approval needed from one of the following (Rule 'Distributed'): Details for Dev Infra teamRaised by workflow job |
awgu
approved these changes
Nov 30, 2022
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
… to testing/_internal/distributed/ (pytorch#89873) Moving checkpoint_utils from Tau: https://github.com/wz337/PiPPy/blob/6acf4054cfd10c8377d65fa1e4f18230d6711edd/spmd/testing/checkpoint_utils.py Checkpoint_utils: add a wrapper to initialize a temp directory for checkpoint testing. Pull Request resolved: pytorch#89873 Approved by: https://github.com/XilunWu, https://github.com/awgu, https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving checkpoint_utils from Tau: https://github.com/wz337/PiPPy/blob/6acf4054cfd10c8377d65fa1e4f18230d6711edd/spmd/testing/checkpoint_utils.py
Checkpoint_utils: add a wrapper to initialize a temp directory for checkpoint testing.