Add setup_context staticmethod to autograd.Function #89859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89859
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b7f36c2: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 29, 2022
zou3519
added
module: autograd
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
soulitzer
reviewed
Nov 30, 2022
samdow
reviewed
Nov 30, 2022
samdow
reviewed
Nov 30, 2022
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
zou3519
commented
Dec 1, 2022
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
soulitzer
reviewed
Dec 2, 2022
Contributor
soulitzer
left a comment
soulitzer
left a comment
There was a problem hiding this comment.
Looks good! But curious what Alban thinks about inputs being expanded.
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests cc ezyang albanD gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests [ghstack-poisoned]
soulitzer
approved these changes
Dec 7, 2022
| Py_INCREF(outputs); | ||
| PyTuple_SET_ITEM(result.get(), 0, (PyObject*)ctx); | ||
| PyTuple_SET_ITEM( | ||
| result.get(), 1, (PyObject*)unpacked_input.input_tuple.get()); |
Contributor
There was a problem hiding this comment.
nit: don't need cast unpacked_input.input_tuple.get() or outputs
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests [ghstack-poisoned]
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests [ghstack-poisoned]
Contributor
|
This pull request has been merged in eb314f9. |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Adds a setup_context staticmethod to autograd.Function. If it exists, then the user splits the ctx-specific logic from the forward() and puts it in the setup_context staticmethod. Docs will come later when we remove the feature flag. Test Plan: - some light tests Pull Request resolved: pytorch#89859 Approved by: https://github.com/soulitzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds a setup_context staticmethod to autograd.Function.
If it exists, then the user splits the ctx-specific logic from the
forward() and puts it in the setup_context staticmethod.
Docs will come later when we remove the feature flag.
Test Plan: