Skip to content

[21/N] Add alltoall_base custom op with CPU/CUDA implementations #89813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H-Huang wants to merge 2 commits into from
Closed

[21/N] Add alltoall_base custom op with CPU/CUDA implementations #89813

H-Huang wants to merge 2 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Nov 29, 2022 •
edited
Loading

Stack from ghstack:

Context

#86225

Differential Revision: D41812670

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Nov 29, 2022
@H-Huang H-Huang mentioned this pull request Nov 29, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89813

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 98959fe:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 29, 2022
Closed
Closed
@H-Huang
Copy link
Member Author

H-Huang commented Nov 29, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@H-Huang
Copy link
Member Author

H-Huang commented Dec 1, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang
Copy link
Member Author

H-Huang commented Dec 6, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang H-Huang requested a review from wanchaol as a code owner December 7, 2022 19:04
@H-Huang
Copy link
Member Author

H-Huang commented Dec 7, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang H-Huang added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
kwen2501
kwen2501 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@H-Huang
Copy link
Member Author

H-Huang commented Dec 8, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 8, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@H-Huang @kulinseth
[21/N] Add alltoall_base custom op with CPU/CUDA implementations (pyt…
6c735e7 
…orch#89813)

Differential Revision: [D41812670](https://our.internmc.facebook.com/intern/diff/D41812670)
Pull Request resolved: pytorch#89813
Approved by: https://github.com/kwen2501
hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@H-Huang
[21/N] Add alltoall_base custom op with CPU/CUDA implementations
ec16ee4 
ghstack-source-id: 5ddf27e
Pull Request resolved: pytorch/pytorch#89813
hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@H-Huang
[21/N] Add alltoall_base custom op with CPU/CUDA implementations
01ae919 
ghstack-source-id: 1007c3d
Pull Request resolved: pytorch/pytorch#89813
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/99/head branch June 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @pytorchmergebot @kwen2501