[Quant][fx][bc-breaking] Remove backend_config_utils.py #89810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously under torch/ao/quantization we have backend_config/utils.py and fx/backend_config_utils.py, which was confusing. This commit deletes the latter and moves everything there to more suitable util files. BC-breaking note: The following public APIs under the `torch.ao.quantization.fx.backend_config_utils` namespace are removed in this commit. ``` get_quantize_handler_cls get_fusion_pattern_to_fuse_handler_cls get_native_quant_patterns get_pattern_to_quantize_handlers ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89810
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 63233b3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
oncall: quantization
jerryzh168
approved these changes
Nov 29, 2022
Summary: Previously under torch/ao/quantization we have backend_config/utils.py and fx/backend_config_utils.py, which was confusing. This commit deletes the latter and moves everything there to more suitable util files. BC-breaking note: The following public APIs under the `torch.ao.quantization.fx.backend_config_utils` namespace are removed in this commit. ``` get_quantize_handler_cls get_fusion_pattern_to_fuse_handler_cls get_native_quant_patterns get_pattern_to_quantize_handlers ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
andrewor14
added a commit
that referenced
this pull request
Nov 29, 2022
Summary: Previously under torch/ao/quantization we have backend_config/utils.py and fx/backend_config_utils.py, which was confusing. This commit deletes the latter and moves everything there to more suitable util files. BC-breaking note: The following public APIs under the `torch.ao.quantization.fx.backend_config_utils` namespace are removed in this commit. ``` get_quantize_handler_cls get_fusion_pattern_to_fuse_handler_cls get_native_quant_patterns get_pattern_to_quantize_handlers ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo ghstack-source-id: 60fbdf6 Pull Request resolved: #89810
andrewor14
added
module: bc-breaking
andrewor14
added
topic: improvements
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: Previously under torch/ao/quantization we have backend_config/utils.py and fx/backend_config_utils.py, which was confusing. This commit deletes the latter and moves everything there to more suitable util files. BC-breaking note: The following public APIs under the `torch.ao.quantization.fx.backend_config_utils` namespace are removed in this commit. ``` get_quantize_handler_cls get_fusion_pattern_to_fuse_handler_cls get_native_quant_patterns get_pattern_to_quantize_handlers ``` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: jerryzh168, vkuzo Subscribers: jerryzh168, vkuzo Pull Request resolved: pytorch#89810 Approved by: https://github.com/jerryzh168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Previously under torch/ao/quantization we have
backend_config/utils.py and fx/backend_config_utils.py, which
was confusing. This commit deletes the latter and moves
everything there to more suitable util files.
BC-breaking note: The following public APIs
are removed in this commit.
Before:
After:
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers: jerryzh168, vkuzo
Subscribers: jerryzh168, vkuzo
cc @ezyang @gchanan @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel