Skip to content

[ONNX] Introduce ONNX reference evaluator for verification #89808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BowenBao wants to merge 8 commits into from
Closed

[ONNX] Introduce ONNX reference evaluator for verification #89808

BowenBao wants to merge 8 commits into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Nov 29, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by unable to bump onnx submodule version, like in #83201. Local tests pass.

@BowenBao BowenBao mentioned this pull request Nov 29, 2022
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Nov 29, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89808

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit ab45bc8:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao BowenBao mentioned this pull request Nov 29, 2022
Closed
BowenBao added a commit that referenced this pull request Nov 29, 2022
@BowenBao
[ONNX] Introduce ONNX reference evaluator for verification
72daa2e 
ghstack-source-id: 49e9323
Pull Request resolved: #89808
This was referenced Nov 30, 2022
Closed
Closed
@BowenBao BowenBao added topic: new features topic category topic: improvements topic category labels Nov 30, 2022
@BowenBao BowenBao marked this pull request as ready for review November 30, 2022 20:18
@BowenBao BowenBao requested a review from abock as a code owner November 30, 2022 20:18
justinchuby
justinchuby reviewed Nov 30, 2022
View reviewed changes
justinchuby
justinchuby reviewed Nov 30, 2022
View reviewed changes
justinchuby
justinchuby approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@titaiwangms
Copy link
Collaborator

titaiwangms commented Dec 2, 2022 •
edited
Loading

Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by #83201. Local tests pass.

I am not sure if #83201 includes all reference evaluator code, as I see some of "reference implementation" PR after Aug 10. I guess we will have to update it to formal ONNX 1.13 release?

@BowenBao
Copy link
Collaborator Author

BowenBao commented Dec 5, 2022

Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by #83201. Local tests pass.

I am not sure if #83201 includes all reference evaluator code, as I see some of "reference implementation" PR after Aug 10. I guess we will have to update it to formal ONNX 1.13 release?

Yes you are right. I should write it as blocked by unable to bump onnx submodule version ..

@titaiwangms
Copy link
Collaborator

titaiwangms commented Dec 5, 2022 •
edited
Loading

Yes you are right. I should write it as blocked by unable to bump onnx submodule version ..

I am updating the ONNX version on that PR to 1.13.0rc

@BowenBao
Update on "[ONNX] Introduce ONNX reference evaluator for verification"
32eeea8 
Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by unable to bump onnx submodule version, like in #83201. Local tests pass.


[ghstack-poisoned]
@BowenBao
Update on "[ONNX] Introduce ONNX reference evaluator for verification"
a7df480 
Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by unable to bump onnx submodule version, like in #83201. Local tests pass.


[ghstack-poisoned]
@BowenBao
Update on "[ONNX] Introduce ONNX reference evaluator for verification"
ab45bc8 
Reference evaluator requires ONNX >= 1.13. Running in CI is blocked by unable to bump onnx submodule version, like in #83201. Local tests pass.


[ghstack-poisoned]
@BowenBao
Copy link
Collaborator Author

BowenBao commented Dec 9, 2022

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 10, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

BowenBao commented Dec 10, 2022

@pytorchbot merge -f "unrelated failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 10, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/178/head branch June 8, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@abock abock Awaiting requested review from abock

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BowenBao @titaiwangms @pytorchmergebot @justinchuby @pytorchbot