Skip to content

[ONNX] Use VerificationOptions to wrap option arguments #89807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BowenBao wants to merge 7 commits into from
Closed

[ONNX] Use VerificationOptions to wrap option arguments #89807

BowenBao wants to merge 7 commits into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Nov 29, 2022 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89807

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 18a33a3:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Nov 29, 2022
@BowenBao BowenBao mentioned this pull request Nov 29, 2022
Closed
@BowenBao BowenBao mentioned this pull request Nov 29, 2022
Closed
This was referenced Nov 30, 2022
Closed
Closed
@BowenBao BowenBao changed the title [ONNX] Use _VerificationOptions to wrap details [ONNX] Use VerificationOptions to wrap option arguments Nov 30, 2022
@BowenBao BowenBao added the topic: improvements topic category label Nov 30, 2022
@BowenBao BowenBao marked this pull request as ready for review November 30, 2022 20:17
@BowenBao BowenBao requested a review from abock as a code owner November 30, 2022 20:18
justinchuby
justinchuby reviewed Nov 30, 2022
View reviewed changes
titaiwangms
titaiwangms approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@BowenBao
Copy link
Collaborator Author

BowenBao commented Dec 9, 2022

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

BowenBao commented Dec 9, 2022

@pytorchbot merge -f "flaky cuda failure"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/177/head branch June 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

@abock abock Awaiting requested review from abock

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BowenBao @pytorchmergebot @justinchuby @titaiwangms @pytorchbot