Implement checks for vmap escaped errors #89585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89585
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3a74733: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
srossross
added
the
release notes: torch.func
Collaborator
Author
|
@kshitij12345 do you think it is worth while spending the time to implement new tests for each of these changes? |
Collaborator
|
I think that would make sense (maybe an OpInfo test to confirm all the ops throw an error). However, let's wait for @zou3519 to confirm (as I don't know much about this part of the code). Thanks! |
srossross
force-pushed
the
assert_to_check
branch
from
63899df to
c84da3b
Compare
srossross
force-pushed
the
assert_to_check
branch
4 times, most recently
from
5a1bf87 to
ea10122
Compare
srossross
force-pushed
the
assert_to_check-remaining
branch
from
d8ba5cb to
8974ee0
Compare
srossross
commented
Dec 6, 2022
bdhirsh
added
the
triaged
zou3519
approved these changes
Dec 7, 2022
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Follow on to pytorch#89077 Pull Request resolved: pytorch#89585 Approved by: https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #89077