Meta impl for linalg_cholesky and linalg_cholesky_ex #89430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89430
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 52f377c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
miladm,
voznesenskym and
wconstab
[ghstack-poisoned]
[ghstack-poisoned]
ezyang
reviewed
Nov 21, 2022
torch/_meta_registrations.py
Outdated
| strides[i] = strides[i + 1] * max(sizes[i + 1], 1) | ||
| i -= 1 | ||
|
|
||
| return strides |
Contributor
There was a problem hiding this comment.
I feel like we've already got ac opy of this function floating around in python
Contributor
Author
There was a problem hiding this comment.
yeah you are right make_contiguous_strides_for in torch/_prims_common/__init__.py
ezyang
approved these changes
Nov 21, 2022
[ghstack-poisoned]
[ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Pull Request resolved: pytorch#89430 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):