[Profiler] Memory profiler part 13: Add sizes to timeline. #89356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89356
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cfae7c2: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 19, 2022
robieta
pushed a commit
that referenced
this pull request
Nov 19, 2022
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) ghstack-source-id: 174078158 Pull Request resolved: #89356
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Nov 22, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174223953 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Nov 27, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174422769 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Nov 29, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174633852 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Nov 30, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174685527 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Nov 30, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174760327 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
robieta
added
ciflow/trunk
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Dec 1, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174825887 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Dec 1, 2022
Pull Request resolved: #89356 If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. ghstack-source-id: 174868149 Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/)
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: PR #89356 has not been reviewed yet (Rule superuser) Details for Dev Infra teamRaised by workflow job |
chaekit
approved these changes
Dec 2, 2022
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…9356) If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage. Differential Revision: [D40868660](https://our.internmc.facebook.com/intern/diff/D40868660/) Pull Request resolved: pytorch#89356 Approved by: https://github.com/chaekit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If we see an allocation the size is unambiguous. Otherwise we have to use sizes and strides to bound the underlying storage.
Differential Revision: D40868660