Skip to content

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Nov 18, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89291

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2a45fec:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Nov 18, 2022
titaiwangms added a commit that referenced this pull request Nov 18, 2022
@titaiwangms titaiwangms added topic: improvements topic category module: onnx Related to torch.onnx labels Nov 18, 2022
@titaiwangms titaiwangms mentioned this pull request Nov 18, 2022
2 tasks
titaiwangms added a commit that referenced this pull request Nov 18, 2022
@titaiwangms titaiwangms linked an issue Nov 18, 2022 that may be closed by this pull request
2 tasks
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Nov 20, 2022

I can't reproduce this in any case. The warning was introduced way back to #22515. I guess it was intended to be double check for the version, and then developers are just stacking up the code. As long as this is not creating issues, and blocking anyone, I think we can ignore it for now. Solving this simply benefits to opset < 9 which isn't even the main opset versions we support anymore. But fixing it might break something that we don't know about yet. Close this PR and issue.

@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/28/head branch June 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ONNX] Remove spammy warnings

4 participants