Skip to content

[PT-D][1/N] Sync TP Beta change to prod #89242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fduwjj wants to merge 8 commits into from
Closed

[PT-D][1/N] Sync TP Beta change to prod #89242

fduwjj wants to merge 8 commits into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Nov 17, 2022

This is part of TP Beta Release efforts.

ref: pytorch/PiPPy#576

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89242

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 Failures

As of commit 4548389:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 17, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj fduwjj added the release notes: distributed (dtensor) release notes category label Nov 17, 2022
wanchaol
wanchaol approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! please make sure CI pass before landing

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 17, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 18, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: 4 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (jit_legacy, 1, 1, linux.4xlarge.nvidia.gpu) ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 4, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge -f trunk test failure only.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: test failure only.

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge -f "CI failure is in trunk not this PR related."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@fduwjj @kulinseth
[PT-D][1/N] Sync TP Beta change to prod (pytorch#89242)
969c774 
This is part of TP Beta Release efforts.

ref: pytorch/PiPPy#576

Pull Request resolved: pytorch#89242
Approved by: https://github.com/wanchaol
@github-actions github-actions bot deleted the sync_tp branch May 30, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fduwjj @facebook-github-bot @pytorchmergebot @wanchaol