[xnnpack][executorch] remove unordered_set from xnn_compiler #89231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unrodered_set from xnncompiler for executorch. While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways After this, the backend classes should be good to hg copy into executorch Differential Revision: [D41227391](https://our.internmc.facebook.com/intern/diff/D41227391/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89231
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 01351bd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Removing unrodered_set from xnncompiler for executorch. While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways After this, the backend classes should be good to hg copy into executorch Differential Revision: [D41227391](https://our.internmc.facebook.com/intern/diff/D41227391/) [ghstack-poisoned]
cccclai
approved these changes
Nov 17, 2022
Removing unrodered_set from xnncompiler for executorch. While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways After this, the backend classes should be good to hg copy into executorch Differential Revision: [D41227391](https://our.internmc.facebook.com/intern/diff/D41227391/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Nov 17, 2022
Pull Request resolved: #89231 Removing unrodered_set from xnncompiler for executorch. While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways After this, the backend classes should be good to hg copy into executorch ghstack-source-id: 173963392 Differential Revision: [D41227391](https://our.internmc.facebook.com/intern/diff/D41227391/)
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…#89231) Removing unrodered_set from xnncompiler for executorch. While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways After this, the backend classes should be good to hg copy into executorch Differential Revision: [D41227391](https://our.internmc.facebook.com/intern/diff/D41227391/) Pull Request resolved: pytorch#89231 Approved by: https://github.com/salilsdesai, https://github.com/cccclai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Removing unrodered_set from xnncompiler for executorch.
While some STL libraries are unavoidable, and I think it should be ok for delegate to pull these libraries, unordered_set wasn't really needed, and we should be serializing the number of external ids anyways
After this, the backend classes should be good to hg copy into executorch
Differential Revision: D41227391