[xnnpack][executorch] Pass xnnexecutor pointer to compileModel() #89090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch: ``` XNNExecutor compileModel(void* buffer) --> void compileModel(void* buffer, XNNExecutor* executor) ``` The intended usecase for allocating Executor and Compiling the serialized flatbuffer: ``` XNNExecutor* executor = runtime_allocator->allocateList<jit::xnnpack::delegate::XNNExecutor>(1); XNNCompiler::compileModel(processed.buffer, executor); ``` Differential Revision: [D41208387](https://our.internmc.facebook.com/intern/diff/D41208387/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89090
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e07c7c3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 15, 2022
mcr229
added a commit
that referenced
this pull request
Nov 15, 2022
Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch: ``` XNNExecutor compileModel(void* buffer) --> void compileModel(void* buffer, XNNExecutor* executor) ``` The intended usecase for allocating Executor and Compiling the serialized flatbuffer: ``` XNNExecutor* executor = runtime_allocator->allocateList<jit::xnnpack::delegate::XNNExecutor>(1); XNNCompiler::compileModel(processed.buffer, executor); ``` Differential Revision: [D41208387](https://our.internmc.facebook.com/intern/diff/D41208387/) ghstack-source-id: 173694755 Pull Request resolved: #89090
…odel()" Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch: ``` XNNExecutor compileModel(void* buffer) --> void compileModel(void* buffer, XNNExecutor* executor) ``` The intended usecase for allocating Executor and Compiling the serialized flatbuffer: ``` XNNExecutor* executor = runtime_allocator->allocateList<jit::xnnpack::delegate::XNNExecutor>(1); XNNCompiler::compileModel(processed.buffer, executor); ``` Differential Revision: [D41208387](https://our.internmc.facebook.com/intern/diff/D41208387/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Nov 16, 2022
Pull Request resolved: #89090 Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch: ``` XNNExecutor compileModel(void* buffer) --> void compileModel(void* buffer, XNNExecutor* executor) ``` The intended usecase for allocating Executor and Compiling the serialized flatbuffer: ``` XNNExecutor* executor = runtime_allocator->allocateList<jit::xnnpack::delegate::XNNExecutor>(1); XNNCompiler::compileModel(processed.buffer, executor); ``` ghstack-source-id: 173816017 Differential Revision: [D41208387](https://our.internmc.facebook.com/intern/diff/D41208387/)
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…orch#89090) Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch: ``` XNNExecutor compileModel(void* buffer) --> void compileModel(void* buffer, XNNExecutor* executor) ``` The intended usecase for allocating Executor and Compiling the serialized flatbuffer: ``` XNNExecutor* executor = runtime_allocator->allocateList<jit::xnnpack::delegate::XNNExecutor>(1); XNNCompiler::compileModel(processed.buffer, executor); ``` Differential Revision: [D41208387](https://our.internmc.facebook.com/intern/diff/D41208387/) Pull Request resolved: pytorch#89090 Approved by: https://github.com/digantdesai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Here we pass XNNExecutor* to compile model so that XNNExecutor can be allocated by runtime. This signature change is for executorch:
The intended usecase for allocating Executor and Compiling the serialized flatbuffer:
Differential Revision: D41208387