Skip to content

[17/N] Add _reduce_scatter_base custom op with CPU/CUDA implementation #88903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
H-Huang wants to merge 3 commits into from
Closed

[17/N] Add _reduce_scatter_base custom op with CPU/CUDA implementation #88903

H-Huang wants to merge 3 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Nov 11, 2022 •
edited
Loading

Stack from ghstack:

Context

#86225

Differential Revision: D41415325

@H-Huang H-Huang mentioned this pull request Nov 11, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88903

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 6bbea20:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@H-Huang H-Huang mentioned this pull request Nov 11, 2022
Closed
@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
kwen2501
kwen2501 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

This was referenced Nov 18, 2022
Closed
Closed
@H-Huang H-Huang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 18, 2022
@H-Huang
Copy link
Member Author

H-Huang commented Nov 18, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang
Copy link
Member Author

H-Huang commented Nov 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Nov 22, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Nov 22, 2022

@pytorchbot merge -f "Unrelated failure: RuntimeError: test_jit_cuda_fuser failed! Received signal: SIGIOT"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@H-Huang H-Huang mentioned this pull request Nov 22, 2022
Closed
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@H-Huang @kulinseth
[17/N] Add _reduce_scatter_base custom op with CPU/CUDA implementation (
a3d3cdf 
pytorch#88903)

Differential Revision: [D41415325](https://our.internmc.facebook.com/intern/diff/D41415325)
Pull Request resolved: pytorch#88903
Approved by: https://github.com/kwen2501
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/95/head branch June 8, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @pytorchmergebot @kwen2501