-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Add support for fmod on MPS #88899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fmod on MPS #88899
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88899
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit f4b598e: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I replicated how |
|
We don't have support for i64 support for floor op: @pumetu , can you please raise an error for i64 type not being supported for the |
|
@kulinseth Added a check for i64 in |
kulinseth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@kulinseth Are you able to force merge the issue as CUDA errors are unrelated to MPS? |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
https://github.com/pytorch/pytorch/actions/runs/3490499797/jobs/5848016852#logs |
Fixes #86810
fmodnow supported on MPS