Skip to content

Conversation

@pumetu
Copy link
Contributor

@pumetu pumetu commented Nov 11, 2022

Fixes #86810
fmod now supported on MPS

@pumetu pumetu requested a review from kulinseth as a code owner November 11, 2022 19:10
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88899

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f4b598e:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Nov 11, 2022
@pumetu
Copy link
Contributor Author

pumetu commented Nov 11, 2022

I replicated how std::fmod was implemented in C++ for this functionality.

@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 14, 2022
@kulinseth
Copy link
Collaborator

We don't have support for i64 support for floor op:

 (null) Function floorOp_i64 was not found in the library'

@pumetu , can you please raise an error for i64 type not being supported for the fmod op.

@pumetu
Copy link
Contributor Author

pumetu commented Nov 17, 2022

@kulinseth Added a check for i64 in fmod.

Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pumetu
Copy link
Contributor Author

pumetu commented Dec 7, 2022

@kulinseth Are you able to force merge the issue as CUDA errors are unrelated to MPS?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Feb 5, 2023
@YankoFelipe
Copy link

https://github.com/pytorch/pytorch/actions/runs/3490499797/jobs/5848016852#logs
@kulinseth @pumetu can this failure be fixed so that the code can be merged?

@kulinseth
Copy link
Collaborator

@pumetu , thanks for this PR. We ended up enabling the Op to make it to PyTorch 2.0 release. #94722

@kulinseth kulinseth closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) open source release notes: mps Release notes category Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MPS] Add support for aten::fmod.Tensor_out for MPS backend

6 participants