Skip to content

[C10D][BE] Add device info to c10d scuba logging #88597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wz337 wants to merge 1 commit into from
Closed

[C10D][BE] Add device info to c10d scuba logging #88597

wz337 wants to merge 1 commit into from

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Nov 7, 2022

Summary: As title.

Test Plan: CI.

Differential Revision: D41090731

@wz337 @facebook-github-bot
[C10D][BE] Add device info to c10d scuba logging
fd4ae08 
Summary: As title.

Test Plan: CI.

Differential Revision: D41090731

fbshipit-source-id: c6512175abbfad0b8ce46e2bea008d170db98512
@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Nov 7, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88597

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit fd4ae08:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 7, 2022

This pull request was exported from Phabricator. Differential Revision: D41090731

H-Huang
H-Huang reviewed Nov 7, 2022
View reviewed changes
torch/distributed/distributed_c10d.py
"func_name": f"{func.__name__}",
"args": f"{args}, {kwargs}",
"backend": f"{get_backend()}",
"device": f"{_get_pg_device(kwargs.get('group'))}",
Copy link
Member

@H-Huang H-Huang Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, _get_pg_device may be deprecated or changed due to the changes in #88330 which convert all PG-specifics instances to type Backend

Copy link
Contributor Author

@wz337 wz337 Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info. Will wait for the change then.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@wz337 wz337 closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H-Huang H-Huang H-Huang left review comments

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

fb-exported release notes: distributed (c10d) release notes category Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wz337 @facebook-github-bot @H-Huang