Skip to content

Add meta support for scalar_tensor and argmax #88590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 15 commits into from
Closed

Add meta support for scalar_tensor and argmax #88590

anjali411 wants to merge 15 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Nov 7, 2022 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88590

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bafb5fc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang
ezyang reviewed Nov 7, 2022
View reviewed changes
ezyang
ezyang reviewed Nov 7, 2022
View reviewed changes
anjali411 added a commit that referenced this pull request Nov 7, 2022
@anjali411
Add meta support for scalar_tensor and argmax
b27e1f7 
ghstack-source-id: cd8c021
Pull Request resolved: #88590
ezyang
ezyang reviewed Nov 7, 2022
View reviewed changes
@anjali411 anjali411 added the release notes: composability release notes category label Nov 8, 2022
anjali411 added a commit that referenced this pull request Nov 8, 2022
@anjali411
Add meta support for scalar_tensor and argmax
cf0b5c7 
ghstack-source-id: 784b69e
Pull Request resolved: #88590
@anjali411 anjali411 mentioned this pull request Nov 8, 2022
Closed
@anjali411 anjali411 requested a review from zou3519 as a code owner November 9, 2022 13:07
This was referenced Nov 9, 2022
Closed
Closed
mruberry
mruberry reviewed Nov 10, 2022
View reviewed changes
ngimel
ngimel reviewed Nov 10, 2022
View reviewed changes
@anjali411
Copy link
Contributor Author

anjali411 commented Nov 10, 2022

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 10, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 10, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 10, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@anjali411
Copy link
Contributor Author

anjali411 commented Nov 11, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 11, 2022

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@anjali411 @kulinseth
Add meta support for scalar_tensor and argmax (pytorch#88590)
2717d80 
Pull Request resolved: pytorch#88590
Approved by: https://github.com/albanD
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/217/head branch June 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

@ngimel ngimel ngimel left review comments

@mruberry mruberry mruberry left review comments

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anjali411 @pytorchmergebot @ezyang @albanD @ngimel @mruberry