[dtensor] PART 4: move remaining DTensor ops to core distributed #88550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88550
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e210585: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 6, 2022
…ibuted" This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs [ghstack-poisoned]
…ibuted" This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs [ghstack-poisoned]
…ibuted" This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs [ghstack-poisoned]
…ibuted" This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs [ghstack-poisoned]
fduwjj
approved these changes
Nov 14, 2022
Contributor
fduwjj
left a comment
fduwjj
left a comment
There was a problem hiding this comment.
The view op is indeed very complicated. Thanks! LGTM.
…ibuted" This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs part of #88838 [ghstack-poisoned]
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…orch#88550) This PR moves the view related DTensor ops to core distributed, tests will be add in follow up PRs part of pytorch#88838 Pull Request resolved: pytorch#88550 Approved by: https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR moves the view related DTensor ops to core distributed,
tests will be add in follow up PRs
part of #88838